Open
Conversation
wwwjn
requested changes
Feb 23, 2026
Contributor
wwwjn
left a comment
There was a problem hiding this comment.
I updated this PR to use new Config System, you can use it as a reference for the RoPE part : #2191
But this PR contains more - It redesigns the RL side config system so it might go through several rounds of review. If you want to land your fix first, I'm also ok with it
4ac7fd8 to
53df656
Compare
wwwjn
reviewed
Feb 24, 2026
53df656 to
ac6c2b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the config changes in #2386 the scripts for RL fail on main.
This PR modifies the code to restore them
Test Plan
Simple RL
output:
Simple Multiprocess RL