Add RL artifacts directories to .gitignore#2407
Open
daniellepintz wants to merge 4 commits intomainfrom
Open
Conversation
daniellepintz
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
joecummings
approved these changes
Feb 20, 2026
wwwjn
reviewed
Feb 20, 2026
.gitignore
Outdated
| # env files | ||
| .env | ||
|
|
||
| # Local checkpoints/models |
Contributor
There was a problem hiding this comment.
These are temporary folders which should be removed in later version. In short, we don't want to experiment folders to affect core torchtitan. models might accidentally ignore some other folders. I prefer delay this change
Contributor
There was a problem hiding this comment.
wwwjn
requested changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two directories (converted/ and models/) are created when running:
We don't want to commit these so adding them to
.gitignore.