Use CSS only solution to handle anchor margin and speed up scroll#217
Open
ezyang wants to merge 2 commits intopytorch_sphinx_theme2from
Open
Use CSS only solution to handle anchor margin and speed up scroll#217ezyang wants to merge 2 commits intopytorch_sphinx_theme2from
ezyang wants to merge 2 commits intopytorch_sphinx_theme2from
Conversation
sphinx gallery 0.11.1 puts it 2nd, but 0.17.1 puts it first, so the wrong link gets used Made change in js/theme.js then ran `grunt build` and a bunch of stuff got generated, no idea if that's correct, so I ended up not committing the `grunt build` changes and just made the change manually in the static folder
Signed-off-by: Edward Yang <ezyang@meta.com>
ezyang
commented
Jan 15, 2026
| } | ||
| } | ||
| var notebookDownloadPath = notebookLink.split('_downloads')[1]; | ||
| var colabLink = "https://colab.research.google.com/github/pytorch/tutorials/blob/gh-pages/_downloads" + notebookDownloadPath; |
Contributor
Author
There was a problem hiding this comment.
uhh I'm not sure what this is lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Yang ezyang@meta.com