Restore the gtag JavaScript function to re-enable metrics#188
Open
carljparker wants to merge 1 commit intomasterfrom
Open
Restore the gtag JavaScript function to re-enable metrics#188carljparker wants to merge 1 commit intomasterfrom
carljparker wants to merge 1 commit intomasterfrom
Conversation
The associated issue is in the pytorch/tutorials repository: Issue #2696 · [BUG] No longer collecting star-rating data...since transition to GA4 pytorch/tutorials#2696 The gtag function is used by metrics such as star-rating in the tutorials repository (which leverages pytorch_sphinx_theme). The definition for the gtag function was deleted in the transition to Google Analytics 4 (GA4) in PR#182, which in-turn broke our metrics. This commit restores the definition of the function to re-enable these metrics.
svekars
approved these changes
Dec 6, 2023
Contributor
svekars
left a comment
svekars
left a comment
There was a problem hiding this comment.
I do not have a way to test this but approving to unblock. Make sure to verify that this is indeed working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The associated issue is in the pytorch/tutorials repository:
Issue #2696 · [BUG]
No longer collecting star-rating data...since transition to GA4 pytorch/tutorials#2696
The gtag function is used by metrics such as star-rating in the tutorials repository (which leverages pytorch_sphinx_theme).
The definition for the gtag function was deleted in the transition to Google Analytics 4 (GA4) in PR#182, which in-turn broke our metrics.
This commit restores the definition of the function to re-enable these metrics.