Open
Conversation
Contributor
|
Sorry for the late response. I know this is a valid issue. Did you have a chance to test this against Sphinx version 5.0 and older? A lot of pytorch sites still use the older version. |
Contributor
Author
|
@svekars Sorry that I don't have time to test it recently. If it's not in a hurry, I may test that during Christmas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stylevariable is deprecated insphinx 7.0.0. However, in currentpytorch_sphinx_theme, we are still using it.pytorch_sphinx_theme/pytorch_sphinx_theme/layout.html
Lines 43 to 45 in a1dbd5c
Following is the solution from
sphinx-rtd-theme:https://github.com/readthedocs/sphinx_rtd_theme/blob/03a86b803cf7cf281748ef94345ba7c35953952a/sphinx_rtd_theme/layout.html#L26-L30
They add an if condition for compatibility with very old
sphinx<4.0. I think we can just remove those codes.https://www.sphinx-doc.org/en/master/changes.html