Skip to content

Conversation

@alexsquires
Copy link
Collaborator

@alexsquires alexsquires commented May 19, 2020

I've added a documentation section with a focus on writing as opposed to reading. I thought this would be a doss, but turns out it's hard. Happy to be beaten over the head with the opinions of others.

@arm61 arm61 mentioned this pull request May 19, 2020
@arm61
Copy link
Contributor

arm61 commented May 21, 2020

Thoughts:

  • Change title to "Writing documentation", then More-on-Documentation #64 will precede this section as it is explaining how to find and read documentation.
  • Add "reading and finding documentation" to prerequisites
  • Maybe don't contextualise the first paragraph in "research", perhaps "learning and research" (keep the audience open as possible)
  • 'functional' to functional (formating IDGAF really)
  • Make 'the code below solves Bragg's law for an orthorombic crystal to determine the Bragg angle associated with a given miller plane' bold
  • make the # symbol code case
  • # define miller indicies to # define miller indices
  • Are you wanting comments and docstrings to be two separate sections?
  • "emphasis" to "emphasise"
  • "arguemnts" to "arguments"

I like this

@alexsquires
Copy link
Collaborator Author

  • Are you wanting comments and docstrings to be two separate sections?

My thinking here was that docstrings require an appreciation of functions, but I don't feel like an understanding of basic documentation should necessitate understanding functions, so I separated them out. I'm not strongly attached to this way of working though.

@arm61
Copy link
Contributor

arm61 commented May 21, 2020

I personally would be happy with them together, just change the name of that subsection to "Docstrings" or something and add functions to the overall prerequisites (this part will definitely be coming after the functions part in the structure of the book so it should be fine).

@arm61
Copy link
Contributor

arm61 commented May 21, 2020

Happy for you to merge this @alexsquires

@alexsquires alexsquires merged commit ecbcd6b into pythoninchemistry:master May 21, 2020
@arm61 arm61 mentioned this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants