Conversation
Collaborator
Author
|
#37 Has been addressed in the last 3 commits |
…tab to BpfProgram
There was a problem hiding this comment.
Pull Request Overview
This PR ports BCC tutorial examples to PythonBPF by adding support for string operations, including helper functions for working with kernel command names and string reading. The implementation adds infrastructure for char array handling, multi-target assignments, and utility functions for trace parsing.
Key changes:
- Added
commandprobe_read_strBPF helper functions with proper LLVM IR emission - Implemented char array to pointer conversion and string copying for struct fields
- Added utilities for parsing kernel trace output (
trace_pipe,trace_fields)
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
pythonbpf/helper/bpf_helper_handler.py |
Adds handlers for comm and probe_read_str BPF helpers with buffer validation |
pythonbpf/helper/helper_utils.py |
Implements buffer pointer extraction and char array type checking utilities |
pythonbpf/helper/printk_formatter.py |
Refactors expression argument preparation and adds char array formatting support |
pythonbpf/assign_pass.py |
Implements string-to-char-array copying and pointer conversion for assignments |
pythonbpf/allocation_pass.py |
Adds support for multi-target assignments and variable/attribute-based allocation |
pythonbpf/functions/functions_pass.py |
Enables multi-target assignment handling in function bodies |
pythonbpf/codegen.py |
Returns symbol tables from compilation and changes default log level |
pythonbpf/utils.py |
Adds trace pipe utilities for reading and parsing kernel trace output |
pythonbpf/helper/helpers.py |
Adds stub implementations of new helper functions |
BCC-Examples/*.py |
Example programs demonstrating ported BCC tutorial functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports all applicable examples from https://github.com/iovisor/bcc/blob/master/docs/tutorial_bcc_python_developer.md to PythonBPF