Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes a circular dependency issue by implementing dependency inversion to eliminate the delayed import of helper handlers in the expression evaluator. The change introduces a registry pattern that allows the helper module to register its handler with the expression module, rather than the expression module directly importing from the helper module.
- Introduced a
CallHandlerRegistryclass in the expression module to manage call handlers - Moved helper call handling logic from
eval_exprto a registration function in the helper module - Replaced delayed imports and direct helper handling with registry-based delegation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pythonbpf/helper/init.py | Added registration function that sets up helper call handler with the expression module registry |
| pythonbpf/expr/expr_pass.py | Added CallHandlerRegistry class and simplified eval_expr to use registry delegation |
| pythonbpf/expr/init.py | Exported CallHandlerRegistry to make it available for registration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49