Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the map calling convention by changing from function-style calls (last()) to direct attribute access (last) for BPF map operations. The main purpose is to align the map access pattern with the expected syntax for BPF map operations.
- Updated map access syntax from
last().method()tolast.method()in example code - Added debug printing to track AST processing of map calls
- Enhanced function assignment handling to support map method calls through attribute access
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pythonbpf/maps/maps_pass.py | Added debug print statement for AST dump tracking |
| pythonbpf/functions_pass.py | Enhanced assignment handling to support map method calls via attribute access |
| examples/sys_sync.py | Updated map calling convention from function calls to attribute access |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.