Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the BPF helper handling code by extracting functionality from a monolithic module into a more modular structure with separate utility functions and a registry pattern.
- Extract helper utilities into a separate module with common functions for pointer management, string formatting, and data handling
- Implement a registry pattern for BPF helper handlers using decorators for cleaner registration
- Replace hardcoded helper function lists with dynamic registry lookups
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pythonbpf/helper/helper_utils.py | New utility module containing common helper functions for pointer creation, string formatting, and data processing |
| pythonbpf/helper/bpf_helper_handler.py | New module with BPF helper handlers registered using decorator pattern and enum for helper IDs |
| pythonbpf/helper/init.py | Package initialization exposing registry and handler function |
| pythonbpf/functions_pass.py | Updated imports to use new registry pattern instead of hardcoded helper list |
| pythonbpf/expr_pass.py | Updated imports to use new registry pattern |
| pythonbpf/bpf_helper_handler.py | Removed original monolithic helper handler file |
| examples/sys_sync.py | Added blank line |
| examples/struct_and_perf.py | Removed unused variable assignments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
@r41k0u can we merge ? need to do some work on this part. |
Collaborator
Author
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.