-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-74902: add unicode grapheme cluster break algorithm #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+3,784
−3,033
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b79f969
add unicodedata.grapheme_cluster_break()
Vermeille c9a4211
generate unicodedata.c.h with clinic
Vermeille 7f56b78
patchcheck
Vermeille a47de54
add the grapheme cluster break automaton
Vermeille c152171
add my name to Misc/ACKS
Vermeille b103be7
code review fixes
Vermeille c9848e2
rename break_graphemes to iter_graphemes
Vermeille 2dee91e
make GraphemeClusterIterator a GC type
Vermeille a5b3c10
allow iterating only over a range of indices
Vermeille ba1e9b7
Merge branch 'main' into grapheme_cluster_break
serhiy-storchaka ae06154
Add some tests.
serhiy-storchaka 1965ed6
Save Grapheme_Cluster_Break for unassigned code points.
serhiy-storchaka 164d19b
Make "Any" the first entry.
serhiy-storchaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the file header look like?
With string contains tests, I worry about things like
"8.0" in "18.0"matching wrongly. Could the full line be compared?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the same check for normalization tests.