-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-143092: Make CALL_LIST_APPEND and BINARY_OP_INPLACE_ADD_UNICODE normal instructions #143124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-143092: Make CALL_LIST_APPEND and BINARY_OP_INPLACE_ADD_UNICODE normal instructions #143124
Conversation
…ner/cpython into remove_deopt_for_no_progress
|
The changes to
We can make Note: Adding the extra |
This requires an |
|
Wait I think I misunderstood you, let me implement this. |
|
@markshannon I converted both of them to normal instructions. Again, I highly doubt any of them will show up on benchmarks considering how few super instructions we have, and also IIRC the original superinstructions PR only added at most 1% speedup, and that contained LOAD_FAST_LOAD_FAST and friends as well. |
Fixes #143092
These super instructions need to many special cases in the interpreter and JIT. It's best we convert them to normal instructions.
_PyTier2Interpreter#143092