Skip to content

Conversation

@aisk
Copy link
Contributor

@aisk aisk commented Jun 22, 2025

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir labels Jun 22, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jun 22, 2025
@aisk aisk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 22, 2025
@aisk aisk force-pushed the spawn-process-sideeffect branch from 584ba8c to 0e65c2b Compare June 22, 2025 10:09
@aisk aisk requested a review from gpshead as a code owner June 22, 2025 10:09
@aisk aisk removed the docs Documentation in the Doc dir label Jun 22, 2025
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

There is a little problem with the test -- it runs three times (in test_multiprocessing_fork, test_multiprocessing_forkserver and test_multiprocessing_spawn). But several other tests have the same problem.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) December 23, 2025 14:09
@serhiy-storchaka serhiy-storchaka merged commit c2202a7 into python:main Dec 23, 2025
83 of 85 checks passed
@miss-islington-app
Copy link

Thanks @aisk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 23, 2025
…no longer have side effect (pythonGH-135813)

(cherry picked from commit c2202a7)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 23, 2025
…no longer have side effect (pythonGH-135813)

(cherry picked from commit c2202a7)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 23, 2025

GH-143115 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 23, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 23, 2025

GH-143116 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 23, 2025
@aisk aisk deleted the spawn-process-sideeffect branch December 24, 2025 01:59
gpshead pushed a commit that referenced this pull request Dec 24, 2025
… no longer have side effect (GH-135813) (#143116)

gh-109263: Start process from spawn context in multiprocessing no longer have side effect (GH-135813)
(cherry picked from commit c2202a7)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request Dec 24, 2025
… no longer have side effect (GH-135813) (#143115)

gh-109263: Start process from spawn context in multiprocessing no longer have side effect (GH-135813)
(cherry picked from commit c2202a7)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants