Update C[13] neutron scattering cross sections#115
Open
pkienzle wants to merge 3 commits intofix-104-type-hintingfrom
Open
Update C[13] neutron scattering cross sections#115pkienzle wants to merge 3 commits intofix-104-type-hintingfrom
pkienzle wants to merge 3 commits intofix-104-type-hintingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING This PR is based off of fix-104-type-hinting, not master. Update to master after merging #109.
The paper Fisher (2008) also gave values for b+ and b-, along with equations for computing b_c and b_i from b+ and b- so I created table generators to check whether the values are consistent across all isotopes (see below). The values are in good agreement with the measured coherent and incoherent scattering for many elements. For others the table values are inconsistent and the uncertainties are high.
For incoherence on a mixture of isotopes with natural abundances I used the standard formula (mean(b_i²) + var(b_c)) across the isotopes.
I then verified that the formula for b_i on a single isotope was just the variance in b+ and b- fractionally weighted with a I+1:I ratio for isotope spin I. In an attempt to improve consistency, I changed the mixture of isotopes formula to use variance on b+ and b- instead of the standard formula. This did not change the results significantly.
While running the checks I noticed that some of the spins reported in the tables were suspicious. Odd isotopes should have fractional spin and even isotopes should have integer spin. I corrected those elements using the spins from Tables for Crystallography, Volume C chapter 4. I didn't verify that every spin was correct.
Consistency check output: