-
Notifications
You must be signed in to change notification settings - Fork 11
Drop support for end-of-life versions of Python #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b49e56a to
c2910f0
Compare
setup.py
Outdated
| packages=find_packages(where="src"), | ||
| package_data={"priority": ["py.typed"]}, | ||
| package_dir={"": "src"}, | ||
| python_requires=">=3.6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this also be bumped? if we no longer run CI tests, we should not claim it works on these Python versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raise to py38 or py310?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on https://devguide.python.org/versions/, I am more than happy to take 3.10 as new lower bound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done.
setup.py
Outdated
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above - remove these here?
Python versions less than 3.10 are eod-of-life. GitHub Actions `ubuntu-latest` no longer supports Python versions less than 3.8 so let’s drop them so that our CI tests are green.
c2910f0 to
aaffd9c
Compare
Our GitHub Actions currently fail ❌ because
ubuntu-latestno longer supports Python versions less than 3.8 so let’s drop them so that our CI tests are green. ✅Python versions less than 3.10 are end-of-life so perhaps we should drop testing of all EoL versions of Python.