Improve precisedelta to better support rounding and float values.#39
Closed
nuztalgia wants to merge 6 commits intopython-humanize:mainfrom
Closed
Improve precisedelta to better support rounding and float values.#39nuztalgia wants to merge 6 commits intopython-humanize:mainfrom
precisedelta to better support rounding and float values.#39nuztalgia wants to merge 6 commits intopython-humanize:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 99.13% 97.41% -1.73%
==========================================
Files 9 9
Lines 690 695 +5
==========================================
- Hits 684 677 -7
- Misses 6 18 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
e2f2dad to
9ff98f7
Compare
Contributor
Author
|
(Force-pushed to clean up the commit history, since it was getting a bit long. 😅 Let me know if you'd like me to squash it down even more!) This PR now includes one of the commits from #19, to fix the root cause of #14. Thank you, @eldipa! 💜 I've also updated the description (#39 (comment)) to reflect all of the test cases that this PR adds and fixes. |
Contributor
Member
|
Thanks both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
Fixes #20.
Changes proposed in this pull request
floatvalues inprecisedelta.Test cases added to
test_precisedelta_custom_formatTest cases added to
test_precisedelta_multiple_units