Skip to content

Conversation

@nathanjmcdougall
Copy link
Contributor

@nathanjmcdougall nathanjmcdougall commented Dec 19, 2025

The changes in #284 introduced a new ruff rule which was violated by #276. Both have been merged but now the main branch is failing.

Since 284 was merged first, and the 276 branch was "out-of-date" relative to main, the CI for 276 didn't run the new ruff rule and didn't catch this.

I've also got this same fix commit in the two other open PRs (#289, #290).

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #291 will not alter performance

Comparing nathanjmcdougall:fix/comply-with-ruff-rule-for-namespace-deprec (a181106) with main (e4bb1bf)

Summary

✅ 26 untouched
⏩ 23 skipped1

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@seddonym seddonym merged commit 19e36b4 into python-grimp:main Dec 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants