Skip to content

Conversation

@nathanjmcdougall
Copy link
Contributor

@nathanjmcdougall nathanjmcdougall commented Dec 17, 2025

[ ] Add tests for the change. In general, aim for full test coverage at the Python level. Rust tests are optional.
[ ] Add any appropriate documentation.
[ ] Add a summary of changes to the latest section at the top of CHANGELOG.rst. (If it's not there, add it.)
[ ] Add your name to AUTHORS.rst.
[ ] Run just full-check.

Follow up to a comment in #284.

Somewhat opinionated change is to always run the formatter after autofixes - I think this is more ergonomic though.

Again I lean against including this in the changelog.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 17, 2025

CodSpeed Performance Report

Merging #285 will not alter performance

Comparing nathanjmcdougall:doc/tweak-justfile-autofix-config (4d7f919) with main (5899ee0)

Summary

✅ 26 untouched
⏩ 23 skipped1

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@seddonym seddonym self-requested a review December 18, 2025 11:13
Copy link
Collaborator

@seddonym seddonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense - I had assumed these would produce validly formatted code.

@seddonym seddonym merged commit ff6bb84 into python-grimp:main Dec 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants