Skip to content

Conversation

@devendragovil
Copy link
Collaborator

I have made the following changes:

  1. Changed init files to get models in the namespace of the base package
  2. Changed tutorials to reflect the new change

…ly in repo. | Making required changes in tutorials as well
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (80275bb) to head (b6c9e29).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   97.37%   97.41%   +0.03%     
==========================================
  Files          58       58              
  Lines        2059     2087      +28     
==========================================
+ Hits         2005     2033      +28     
  Misses         54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devendragovil devendragovil marked this pull request as ready for review December 2, 2024 18:38
@devendragovil
Copy link
Collaborator Author

@mhajij Please review

@mhajij mhajij requested a review from ffl096 December 2, 2024 18:40
Copy link
Member

@ffl096 ffl096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the ruff error, then this is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants