Replace mixed line ending commit hook with .gitattributes.#474
Open
HexDecimal wants to merge 1 commit intopypa:publicapifrom
Open
Replace mixed line ending commit hook with .gitattributes.#474HexDecimal wants to merge 1 commit intopypa:publicapifrom
HexDecimal wants to merge 1 commit intopypa:publicapifrom
Conversation
This commit hook was preventing me from committing, but since I use autoclrf I don't upload mixed line endings on commits even without a hook preventing it. A .gitattributes file enforces line endings regardless of local settings. This does what this commit hook was intending to do but works better across platforms.
Codecov ReportBase: 68.76% // Head: 68.76% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## publicapi #474 +/- ##
==========================================
Coverage 68.76% 68.76%
==========================================
Files 11 11
Lines 986 986
==========================================
Hits 678 678
Misses 308 308 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit hook was causing me some issues. Since I use
autoclrfI don't upload mixed line endings on commits even without a hook preventing it, but that's a local setting.A .gitattributes file enforces line endings regardless of local settings. This does what this commit hook was intending to do but works better across platforms.