-
Notifications
You must be signed in to change notification settings - Fork 10
Guide polishing :flag_pl: #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: idra-guide-changes
Are you sure you want to change the base?
Conversation
OhmV-IR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good ig but one comment
| val fluidsButton = PageButton(Material.WATER_BUCKET, fluidsPage) | ||
|
|
||
| @JvmStatic | ||
| val infoPage = SimpleStaticGuidePage(pylonKey("info")) | ||
|
|
||
| @JvmStatic | ||
| val infoButton = PageButton(Material.LANTERN, infoPage) | ||
|
|
||
| @JvmStatic | ||
| val researchesPage = ResearchesPage() | ||
|
|
||
| @JvmStatic | ||
| val researchesButton = PageButton(Material.BREWING_STAND, researchesPage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would we like to bother making these 3 pylon items as well so they can be textured by the resource pack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are GUI items internally so can be textured - see PageButton
Seggan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some formatting
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/content/guide/PylonGuide.kt
Outdated
Show resolved
Hide resolved
|
I made in the past in the BasePage a way to do something similar public static final SimpleStaticGuidePage CREATIVE_ITEMS = new SimpleStaticGuidePage(baseKey("creative_items"), Material.BEDROCK) {
@Override
public boolean shouldDisplay(@NotNull Player player) {
return player.hasPermission("pylon.guide.view_admin_pages");
}
};Did you forget or did you want to replace the approach |
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/guide/button/BackButton.kt
Show resolved
Hide resolved
Confused - this code is still there. I haven't changed it? |
Ok mb i got confused for a second in the code, didn't realize i was handling items in the specific for some reason |
Your standard polishing PR; lots of small changes to the guide.