Skip to content

Conversation

@LordIdra
Copy link
Contributor

@LordIdra LordIdra commented Jan 5, 2026

Your standard polishing PR; lots of small changes to the guide.

  • Remove enchantment glint on back button (looks awkward with texture pack)
  • Add extra lore to show controls (eg 'right click to view usages') - 'guide hints'
  • Add settings option to disable guide hints
  • Add text to indicate you can shift+click to go back to root page
  • Use Pylon items instead of just material for guide category icons, so that the texture is shown
  • Fix sugarcane not being hidden in fluids category
  • Show creative items in search if you're an admin
  • Add 'only visible to admins' text to creative items, creative category, and cheat hints (q/middle click)
  • Change back button to not have yellow name
  • Change drop item cheat (pressing Q while hovering over an item) to change the item on your cursor instead of dropping it

Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good ig but one comment

Comment on lines 105 to 117
val fluidsButton = PageButton(Material.WATER_BUCKET, fluidsPage)

@JvmStatic
val infoPage = SimpleStaticGuidePage(pylonKey("info"))

@JvmStatic
val infoButton = PageButton(Material.LANTERN, infoPage)

@JvmStatic
val researchesPage = ResearchesPage()

@JvmStatic
val researchesButton = PageButton(Material.BREWING_STAND, researchesPage)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we like to bother making these 3 pylon items as well so they can be textured by the resource pack?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are GUI items internally so can be textured - see PageButton

Copy link
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting

@LordIdra LordIdra requested a review from OhmV-IR January 5, 2026 22:40
@Intybyte
Copy link
Member

Intybyte commented Jan 7, 2026

I made in the past in the BasePage a way to do something similar

public static final SimpleStaticGuidePage CREATIVE_ITEMS = new SimpleStaticGuidePage(baseKey("creative_items"), Material.BEDROCK) {
        @Override
        public boolean shouldDisplay(@NotNull Player player) {
            return player.hasPermission("pylon.guide.view_admin_pages");
        }
    };

Did you forget or did you want to replace the approach

@LordIdra
Copy link
Contributor Author

LordIdra commented Jan 7, 2026

I made in the past in the BasePage a way to do something similar

public static final SimpleStaticGuidePage CREATIVE_ITEMS = new SimpleStaticGuidePage(baseKey("creative_items"), Material.BEDROCK) {
        @Override
        public boolean shouldDisplay(@NotNull Player player) {
            return player.hasPermission("pylon.guide.view_admin_pages");
        }
    };

Did you forget or did you want to replace the approach

Confused - this code is still there. I haven't changed it?

@Intybyte
Copy link
Member

Intybyte commented Jan 7, 2026

Confused - this code is still there. I haven't changed it?

Ok mb i got confused for a second in the code, didn't realize i was handling items in the specific for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants