Technical guide changes #552
Conversation
OhmV-IR
left a comment
OhmV-IR
left a comment
There was a problem hiding this comment.
lgtm cw & ig w one optional polishing thing
| addSetting( | ||
| TogglePlayerSettingButton( | ||
| pylonKey("toggle-vanilla-waila"), | ||
| toggle = { player -> | ||
| player.wailaConfig.vanillaWailaEnabled = !player.wailaConfig.vanillaWailaEnabled | ||
| }, | ||
| isEnabled = { player -> player.wailaConfig.vanillaWailaEnabled } | ||
| )) |
There was a problem hiding this comment.
would be nice if you could get the dependency of the vanilla waila setting on waila overall being on working. (ie if I turn waila off, vanilla waila setting should respond & I can't turn on vanilla waila if waila is off overall)
There was a problem hiding this comment.
Thought about this a bit, but tbh I don't know if there's necessarily a point, since it's already obvious that vanilla WAILA won't work if WAILA is disabled. and the correct/expected behaviour IMO is to preserve the 'vanilla WAILA' setting when you disable WAILA, rather than changing it
Seggan
left a comment
Seggan
left a comment
There was a problem hiding this comment.
You've got a lost of assuming where keys are, ex assuming page names are under pylon.<youraddon>.guide.page.<key>. I would want a way to allow me to use a different component, for example dynamically generated pages
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/content/guide/PylonGuide.kt
Show resolved
Hide resolved
Could you elaborate on what changes you want here? I'm confused on what exactly you're referring to. I know PageButton does this, the idea was you'd override that or use your own page button if you were doing something fancy enough to want to supply your own components |
This PR prepares for the 'item menu' system I am planning to introduce. The central change is that buttons and pages are now more clearly separated. Previously, a page would have to supply an icon which could then be used by buttons linking to that page. This makes no sense for pages that do not have a button linking to them, which we are about to have a lot of, so I have changed pages to no longer have to supply an item for buttons linking to them.
Other changes:
PylonCorewith settings pages being added in theonEnablemethod)