Cargo polishing #543
Open
Cargo polishing #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LordIdra
commented
Dec 31, 2025
LordIdra
commented
- Renames LogisticSlotType to LogisticGroupType
- Update cargo ticking logic to work with multiple target slots instead of just duplicating the items across all of them lmao
- Fix cargo routes not invalidating in certain situations
- Fix cargo routes with no endpoint not being cached (lol)
- Add logistic slots for vanilla inventories, and a method which gets all the logistic groups for a vanilla block
OhmV-IR
requested changes
Jan 5, 2026
Contributor
OhmV-IR
left a comment
OhmV-IR
left a comment
There was a problem hiding this comment.
that util function bothers me
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/util/PylonUtils.kt
Outdated
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/util/PylonUtils.kt
Outdated
Show resolved
Hide resolved
Seggan
approved these changes
Jan 5, 2026
Comment on lines
+59
to
+60
| val blockData = block?.state | ||
| return when (blockData) { |
Member
There was a problem hiding this comment.
Suggested change
| val blockData = block?.state | |
| return when (blockData) { | |
| return when (val blockData = block?.state) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.