Skip to content

Conversation

@Intybyte
Copy link
Member

No description provided.

Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm struggling to see how any of these additions are going to be reused beyond the crucible, so I think that it should just be made static functions inside of the crucible class in base. If it's unused in core, it definitely shouldn't be in core utils at least.

@LordIdra
Copy link
Contributor

LordIdra commented Jan 5, 2026

I'm struggling to see how any of these additions are going to be reused beyond the crucible, so I think that it should just be made static functions inside of the crucible class in base. If it's unused in core, it definitely shouldn't be in core utils at least.

This is how it was before and I specifically suggested moving it to core because I think this is something we're going to need and addons will almost certainly want to make use of. It's just a set of functions to visualise a namespaced key.

Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok lgtm then

Copy link
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what ItemTypeWrapper is for. ItemTypeWrapper.of(key).createItemStack() go brr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants