This repository was archived by the owner on Aug 15, 2021. It is now read-only.
Deserialize undefined as None for Option
#218
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBOR knows these two types (spec):
0xf6=>null0xf7=>undefinedSerde only knows
Nullafaik, or at least theValueenum doesn't have anything closer to representundefinedthanNull.In order for this to work well with
Optionwe need to treatundefinedthe same asnullwhen deserializing anOption.this popped up when interacting between Rust and JS, when using
{ key: undefined }in JS and reading it intostruct { key: Option<Foo> }