Skip to content

Conversation

@zhewang2001
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 10, 2025 21:34
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @zhewang2001, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've streamlined the data generation scripts by removing the remote_api parameter and its associated logic from cwe2code.py and guru2code.py. This change simplifies the code by eliminating support for an external API endpoint that was no longer needed, ensuring that the scripts consistently use the local OpenAI client. Additionally, I've made a minor adjustment to the base_url for the local client and added a directory creation step for output paths.

Highlights

  • API Client Simplification: The _create_client function in both cwe2code.py and guru2code.py has been simplified by removing the remote_api parameter and its conditional logic, ensuring a consistent local OpenAI client setup.
  • Parameter Removal: The remote_api parameter has been removed from datagen_for_one_cwe in cwe2code.py and datagen_for_one_seed in guru2code.py, along with its corresponding arguments in the main functions.
  • Localhost URL Update: In cwe2code.py, the base_url for the local OpenAI client was updated from http://0.0.0.0:30000/v1 to http://localhost:30000/v1.
  • Output Directory Creation: A new line was added to cwe2code.py's main function to ensure the output directory exists before writing files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

This comment was marked as outdated.

@zhewang2001 zhewang2001 requested review from Copilot and ganler August 10, 2025 21:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the remote_api parameter and related functionality from rule2code data generation scripts, standardizing them to use only local API endpoints.

  • Eliminates remote_api parameter from function signatures and main entry points
  • Removes conditional logic for remote API client creation and batch completion calls
  • Standardizes both scripts to use localhost endpoints exclusively

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
datagen/rule2code/guru2code.py Removes remote_api parameter and simplifies client creation to use only localhost
datagen/rule2code/cwe2code.py Removes remote_api parameter and standardizes client configuration

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the remote_api functionality from the cwe2code.py and guru2code.py scripts, simplifying the codebase to rely solely on a local server. The changes are clean, consistent, and include beneficial improvements such as ensuring the output directory exists before writing and using localhost for the server address for better security. I have one suggestion to clean up unused imports that resulted from these changes.

@ganler ganler merged commit 4eb4e3f into main Aug 10, 2025
2 checks passed
@zhewang2001 zhewang2001 deleted the fix/rule2code branch August 10, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants