-
Notifications
You must be signed in to change notification settings - Fork 1
fix(datagen): remove remote_api from rule2code scripts
#20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @zhewang2001, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've streamlined the data generation scripts by removing the remote_api parameter and its associated logic from cwe2code.py and guru2code.py. This change simplifies the code by eliminating support for an external API endpoint that was no longer needed, ensuring that the scripts consistently use the local OpenAI client. Additionally, I've made a minor adjustment to the base_url for the local client and added a directory creation step for output paths.
Highlights
- API Client Simplification: The
_create_clientfunction in bothcwe2code.pyandguru2code.pyhas been simplified by removing theremote_apiparameter and its conditional logic, ensuring a consistent local OpenAI client setup. - Parameter Removal: The
remote_apiparameter has been removed fromdatagen_for_one_cweincwe2code.pyanddatagen_for_one_seedinguru2code.py, along with its corresponding arguments in themainfunctions. - Localhost URL Update: In
cwe2code.py, thebase_urlfor the local OpenAI client was updated fromhttp://0.0.0.0:30000/v1tohttp://localhost:30000/v1. - Output Directory Creation: A new line was added to
cwe2code.py'smainfunction to ensure the output directory exists before writing files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the remote_api parameter and related functionality from rule2code data generation scripts, standardizing them to use only local API endpoints.
- Eliminates
remote_apiparameter from function signatures and main entry points - Removes conditional logic for remote API client creation and batch completion calls
- Standardizes both scripts to use localhost endpoints exclusively
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| datagen/rule2code/guru2code.py | Removes remote_api parameter and simplifies client creation to use only localhost |
| datagen/rule2code/cwe2code.py | Removes remote_api parameter and standardizes client configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the remote_api functionality from the cwe2code.py and guru2code.py scripts, simplifying the codebase to rely solely on a local server. The changes are clean, consistent, and include beneficial improvements such as ensuring the output directory exists before writing and using localhost for the server address for better security. I have one suggestion to clean up unused imports that resulted from these changes.
No description provided.