Rake task allows for a different commit message#408
Merged
gavindidrichsen merged 1 commit intopuppetlabs:mainfrom Jun 2, 2025
Merged
Rake task allows for a different commit message#408gavindidrichsen merged 1 commit intopuppetlabs:mainfrom
gavindidrichsen merged 1 commit intopuppetlabs:mainfrom
Conversation
ghoneycutt
force-pushed
the
configure_push
branch
4 times, most recently
from
d720ad4 to
fc267d0
Compare
Contributor
Author
|
I tested this works by configuring a rake task to use a different message as well as calling the normal rake tasks here and getting the default message as shown in ghoneycutt/puppet-module-pam#279 |
bastelfreak
reviewed
May 30, 2025
treydock
approved these changes
May 30, 2025
bastelfreak
approved these changes
May 30, 2025
Without this commit, you cannot inform the rake task to push gh-pages to accept a different commit message. This is necessary in environment where commit messages have to be in specific formats. None of the system calls were checking the exit status of their respective commands. Not stopping on error means that the rake take can fail and you and your pipelines would not know.
ghoneycutt
force-pushed
the
configure_push
branch
from
fc267d0 to
f37cb25
Compare
jstraw
approved these changes
May 31, 2025
Contributor
Author
|
@gavindidrichsen Could you please cut a release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this commit, you cannot inform the rake task to push gh-pages to accept a different commit message. This is necessary in environment where commit messages have to be in specific formats.
None of the system calls were checking the exit status of their respective commands. Not stopping on error means that the rake take can fail and you and your pipelines would not know.