Merged
Conversation
|
|
Author
|
Having issues creating a proper ticket -- seems something is fishy with signing up a new account via tickets.puppetlabs.com 🤷 |
|
I'm not sure an issue is really needed. |
|
Here is the right place for community tickets these days 😊. |
|
Small nit. Would it be possible to rebase on main rather than having the merge commit? |
If the token is considered "trailing whitespace" and needs to be deleted, it tries to remove the item from the linked list. However, that doesn't work on the first and last entries. There already is a clause for the last item, just not the first item.
nwoythal
force-pushed
the
fix-first-token-whitespace
branch
from
4abf90e to
d4ec64b
Compare
chelnak
approved these changes
Feb 24, 2023
|
@ekohl Are you happy with this as a continuation of your work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing work from #83 by adding tests
Resolves #81