Link RMW to non-zero byte enable conditions. #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might happen (especially with HWPEs driving part of the byte enable to zero) that sometimes a write happens with
be_i = '0but with a non-zero data on thewdata_ibus. In this particular case, the RMW FSM in the ecc_bank will still detect a RMW case, leading to either write of unproer data into the TCDM, or to deadlock conditions. This PR introduces a new signal that makes the write enable bus asserted only if thebe_iis not all zero during a write operation, and use this to decide if we need to make a RMW or not.Also, the
ecc_errorwas not driven in thegen_ecc_inputcase making the{single/multi}_error_ogo toxquite often.