Skip to content

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Mar 25, 2021

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ electron (^8.2.5 → ^12.0.2) · Repo

Release Notes

12.0.2

Release Notes for v12.0.2

Fixes

  • Colors returned from systemPreferences.getAccentColor(), getSystemColor and getColor are now correctly converted into the devices color space. Previously the color would have been subtly incorrect. #28172 (Also in 11, 13)
  • Fixed desktopCapturer.getSources() promise result sometimes never resolving. #28281 (Also in 10, 11, 13)
  • Fixed a rare crash on Windows that could occur when emitting certain Tray events. #28111
  • Fixed an issue where some Node.js modules would hang on page reload on Windows. #28337 (Also in 13)
  • Fixed an issue where the drag regions in BrowserViews on macOS could be off in their y-axis. #28296 (Also in 10, 11, 13)
  • Fixed context menus not being positioned correctly when near the edge of the screen. #28277 (Also in 11, 13)
  • Fixed crash when calling getBackgroundColor on a transparent window with no assigned background color. #28188 (Also in 11, 13)
  • Fixed intensive I/O from asar files causing ERR_FILE_NOT_FOUND after a while. #28202 (Also in 11, 13)
  • URLS passed to shell.openExternal on windows are now correctly URI encoded. This was already occurring on macOS and Linux. #28341 (Also in 10, 11, 13)

Other Changes

  • Fixed native module compilation with AsyncCleanupHooks on windows. #28109 (Also in 11, 13)
  • Updated Chromium to 89.0.4389.90. #28174

Documentation

  • Documentation changes: #28214

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 19 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 25, 2021
@depfu
Copy link
Contributor Author

depfu bot commented Apr 15, 2021

Closed in favor of #81.

@depfu depfu bot closed this Apr 15, 2021
@depfu depfu bot deleted the depfu/update/npm/electron-12.0.2 branch April 15, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant