Figure out how to get Google Translate to detect non-English language for in-browser translation#8
Open
patcon wants to merge 1 commit intoptt:masterfrom
Open
Figure out how to get Google Translate to detect non-English language for in-browser translation#8patcon wants to merge 1 commit intoptt:masterfrom
patcon wants to merge 1 commit intoptt:masterfrom
Conversation
patcon
changed the title
Author
patcon
force-pushed
the
8-language-detection
branch
from
8b13de2 to
b81d48b
Compare
Author
|
Ready for review, but not tested due to missing templates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile and desktop, Google Translate in Chrome only asks to translate on certain pages, like this one:
On others, it doesn't. Note the lack of translation icon on the right of the browser url bar:
This isn't such a problem on desktop, where I can just right click anywhere on the page and select "Translate to English". But on mobile, there's no way to translate the whole page unless the browser detects it.
Would be rad to figure out how Chrome decides to ask, and ensure all pages have the chance :)
Thanks!