Patch to force opencv fetch + better more relavent tags for opencv full#3
Open
rsarwar87 wants to merge 6 commits intopthom:masterfrom
Open
Patch to force opencv fetch + better more relavent tags for opencv full#3rsarwar87 wants to merge 6 commits intopthom:masterfrom
rsarwar87 wants to merge 6 commits intopthom:masterfrom
Conversation
pthom
force-pushed
the
master
branch
2 times, most recently
from
0e5d33e to
98952f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi pascal
i hope you dont mind, but i did some minor modifications of the cmake to make it force IMMVISION_FETCH_OPENCV, probably could have use a OR install of creating a new if case, but did not want to remove the code.
also updated the flags on full opencv compilation to make it static and disable 1394 stuff.
also imgui_bundle seem to want to fetch_repo twice, so i added a if statement to prevent multiple fetch, which would crash the build. could probably be implemented better my having the check in immvision_fetch_opencv_from_source()