add unit model #230
Open
add unit model #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkiessl
requested changes
Feb 3, 2026
Comment on lines
7
to
8
| t.integer :daily_page_limit | ||
| t.integer :overall_page_limit |
Contributor
There was a problem hiding this comment.
We should probably have these configured as "null: false" and add some defaults just to be sure on the database level we are not getting anything weird. Probably something pretty restrictive like 30 pages a day and 25,000 total. We should confirm with @binkylush that this sounds okay.
Contributor
Author
There was a problem hiding this comment.
Binky confirmed those are a good place to start
app/models/unit.rb
Outdated
Comment on lines
8
to
9
| validates :daily_page_limit, presence: true | ||
| validates :overall_page_limit, presence: true |
Contributor
There was a problem hiding this comment.
I think these would be better like validates :daily_page_limit, numericality: { only_integer: true, greater_than_or_equal_to: 0 }. To be sure we know what we're getting won't cause issues downstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
For now, unit_id is allowed to be null for users so it doesn't break existing users. Once those have been assigned a unit, we should probably update so that users must have a unit to make sure pages are all accounted for