Reject insecure database SSL modes in production#5
Merged
Conversation
Prevent accidental plaintext database connections when APP_ENV=production by rejecting sslmode=disable and sslmode=allow at startup. Also log the active SSL mode during database connection for observability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sslmode=disableandsslmode=allowinDATABASE_URLwhenAPP_ENV=production— startup fails with a clear error message.env.exampleDevelopment, Docker Compose, and CI are unaffected (they use
APP_ENV=development).Test plan
disable,allow, case-insensitive)require,verify-ca,verify-full,prefer, absent)sslmode=disablemake test-shortpassesmake lintpasses🤖 Generated with Claude Code