Refactor/make query a service #374
Conversation
| */ | ||
| private get blockExplorerTransport(): BlockExplorerTransportModule { | ||
| if (this.BlockExplorerTransport === undefined) { | ||
| if (!this.container.isRegistered("BlockExplorerTransportModule")) { |
There was a problem hiding this comment.
We can save this line, tsyringe will throw a more descriptive error when it can't resolve a dependency anyways
There was a problem hiding this comment.
Same for all the others in this class
There was a problem hiding this comment.
Removed since it is injected now: 3385f1d
| AppChainModules extends MinimalAppChainDefinition, | ||
| > extends AppChain<AppChainModules> { | ||
| // Optional for our lazy initialization purpose. | ||
| private QueryService?: QueryService< |
| MandatoryProtocolModulesRecord, | ||
| > { | ||
| // Here, fields are optional for lazy initialization. | ||
| private QueryTransport?: QueryTransportModule; |
There was a problem hiding this comment.
So - I had a bit of a different structure in mind here - and I think this would save a lot of LOCs:
We use all the features the tsyringe gives us.
First, we make the QueryService @injectable() and @scoped(Lifecycle.ContainerScoped)
Then, we inject al the transport module in the constructor using @inject("Token", { isOptional: true }) private readonly module: Module | undefined
And then, we can use this.module for all the actual queries that we have
There was a problem hiding this comment.
Also, in the ClientAppChain, we need to use this.parentContainer.resolve(QueryService)
Description
This PR refactors query logic in
ClientAppChainby extracting it into a dedicatedQueryServiceclass with lazy initialization patterns.Changes
QueryServiceclass with lazy-initialized getters for runtime, protocol, network, and explorer query modules f00c371QueryTransportModule,NetworkStateTransportModule,BlockExplorerTransportModulef00c371QueryServicefor query modules 23b6d4bClientAppChainto useQueryService880358fThis PR closes #349