Fix Pickle Vulnerability Detection Gap #313
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description: Fix Pickle Vulnerability Detection Gap
Summary
Fixes critical detection gaps in pickle vulnerability scanning by improving pickle parsing engine and expanding unsafe globals coverage.
Fixes: #311
Problem
Modelscan was missing significant number of malicious pickle files:
Solution
Enhanced Pickle Parsing Engine
Comprehensive Unsafe Globals Database
Added detection patterns for:
torch._dynamo.guards.GuardBuilder.get,torch.utils.bottleneck.__main__.*,torch.fx.experimental.symbolic_shapes.*, etc.commands,ssl,timeit,ensurepip._run_pipcode.InteractiveInterpreter.runcode,cProfile.run,profile.*idlelib.*,lib2to3.*,pydoc.pipepagerRobust Archive Handling
Test Results
Files Modified
modelscan/tools/picklescanner.py- Core parsing improvementsmodelscan/settings.py- Expanded unsafe globals databasemodelscan/modelscan.py- Enhanced zip error handlingValidation
Test against comprehensive pickle vulnerability suite: Sent in email
This patch transforms modelscan from detecting ~36% to ~100% of malicious pickle files, significantly improving security coverage.
Note: Inspiration from picklescan project.