-
-
Notifications
You must be signed in to change notification settings - Fork 8
Add Origins, HttpInterface, and basic Discord support #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
linc
wants to merge
53
commits into
main
Choose a base branch
from
feat/discord-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29f1cd8 to
41abf85
Compare
d5957a3 to
c8f5b35
Compare
f5f370d to
f9b908a
Compare
c12c04c to
7d241b9
Compare
… into feat/discord-api
This reverts commit a1d4153.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://nitroporter.org/domain.html#domain-diagram
Originas aPackagetypepullcommand to retrieve data from anOriginOriginpackage (pull -> raw data from origin)Sourcepackage & update docssymfony/http-cllientConnectionManagercompatibility with SymfonyClientHttpInterfaceHttpsas aStoragetype & refactor the Storage interfaceRequest()call to use named paramsMigrationfor no reasontranslateDatabaseConfig()(just use direct config names from now on)Assumes
pullwill only be sourced from HTTP APIs (Storage\Https) for simplicity today even though that is likely a faulty long-term assumption; it shouldn't be difficult to extend if/when the time comes.Note that
Origindoesn't useMigration, so it has more property baggage thanSourceet. al. This may be part of the path to deprecating theMigrationobject eventually.