Skip to content

Make 3 unneeded PODTicket fields optional #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artwyman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make 3 unneeded PODTicket fields optional #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions examples/test-app/src/apis/GPC.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,13 +210,10 @@ const ticketData = {
ticketName: "Ticket 1",
eventName: "Event 1",
ticketSecret: "secret123",
timestampConsumed: 1714857600,
timestampSigned: 1714857600,
attendeeSemaphoreId: ${identityV3},
owner: "${publicKey}",
isConsumed: 0,
isRevoked: 0,
ticketCategory: 0,
attendeeName: "John Doe",
attendeeEmail: "test@example.com"
};
Expand All @@ -236,13 +233,13 @@ await z.pod.insert(pod);
ticketName: "Ticket 1",
eventName: "Event 1",
ticketSecret: "secret123",
timestampConsumed: 1714857600,
//timestampConsumed: 1714857600,
timestampSigned: 1714857600,
attendeeSemaphoreId: identityV3!,
owner: publicKey!,
isConsumed: 0,
isRevoked: 0,
ticketCategory: 0,
//isRevoked: 0,
//ticketCategory: 0,
attendeeName: "John Doe",
attendeeEmail: "test@example.com"
};
Expand Down
12 changes: 6 additions & 6 deletions packages/podspec/test/ticket-example.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ const TicketEntries = p.entries({
imageUrl: { type: "optional", innerType: { type: "string" } },
imageAltText: { type: "optional", innerType: { type: "string" } },
ticketSecret: { type: "optional", innerType: { type: "string" } },
timestampConsumed: { type: "int" },
timestampConsumed: { type: "optional", innerType: { type: "int" } },
timestampSigned: { type: "int" },
attendeeSemaphoreId: { type: "cryptographic" },
isConsumed: { type: "int" },
isRevoked: { type: "int" },
ticketCategory: { type: "string" },
isRevoked: { type: "optional", innerType: { type: "int" } },
ticketCategory: { type: "optional", innerType: { type: "int" } },
attendeeName: { type: "string" },
attendeeEmail: { type: "string" }
});
Expand All @@ -51,12 +51,12 @@ const VALID_TICKET_DATA = {
imageUrl: "https://example.com/image.jpg",
imageAltText: "Image 1",
ticketSecret: "secret123",
timestampConsumed: 1714857600,
//timestampConsumed: 1714857600,
timestampSigned: 1714857600,
attendeeSemaphoreId: 1234567890,
isConsumed: 0,
isRevoked: 0,
ticketCategory: "Category 1",
//isRevoked: 0,
//ticketCategory: 1,
attendeeName: "John Doe",
attendeeEmail: "john.doe@example.com"
};
Expand Down
6 changes: 3 additions & 3 deletions packages/ticket-spec/src/ticket_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const TicketSpec = p.pod({
productId: { type: "string" },
ticketName: { type: "string" },
eventName: { type: "string" },
timestampConsumed: { type: "int" },
timestampConsumed: { type: "optional", innerType: { type: "int" } },
timestampSigned: { type: "int" },
// Semaphore v3
attendeeSemaphoreId: {
Expand All @@ -20,8 +20,8 @@ export const TicketSpec = p.pod({
// Semaphore v4
owner: { type: "eddsa_pubkey" },
isConsumed: { type: "int" },
isRevoked: { type: "int" },
ticketCategory: { type: "int" },
isRevoked: { type: "optional", innerType: { type: "int" } },
ticketCategory: { type: "optional", innerType: { type: "int" } },
attendeeName: { type: "string" },
attendeeEmail: { type: "string" },
checkerEmail: { type: "optional", innerType: { type: "string" } },
Expand Down