DogStatsD v1.2 Container ID support with sampling support#649
Open
marc-harrison wants to merge 3 commits intoprometheus:masterfrom
Open
DogStatsD v1.2 Container ID support with sampling support#649marc-harrison wants to merge 3 commits intoprometheus:masterfrom
marc-harrison wants to merge 3 commits intoprometheus:masterfrom
Conversation
Signed-off-by: Marc Harrison <marc@impart.security>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for DogStatsD v1.2 container ID extension, allowing metrics to include container ID information via a |c:<container_id> suffix. The implementation extends the existing parser to handle up to 5 components (increased from 4) and adds parsing logic for the container ID section.
- Increased component limit from 4 to 5 to accommodate the new container ID field
- Added parsing logic for the
|c:<container_id>format with proper validation - Enhanced test coverage for various container ID scenarios including sampling, different metric types, and malformed inputs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/line/line.go | Implements container ID parsing logic and increases component limit |
| pkg/line/line_test.go | Adds comprehensive test cases for container ID functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Marc Harrison <marc@impart.security>
marc-harrison
force-pushed
the
marc/container_id_support_extended
branch
from
b1f9092 to
f68b77b
Compare
Contributor
pedro-stanaka
left a comment
pedro-stanaka
left a comment
There was a problem hiding this comment.
it looks mostly good, the log line will show the wrong message, if I am not mistaken, no?
Signed-off-by: Marc Harrison <marc@impart.security>
marc-harrison
force-pushed
the
marc/container_id_support_extended
branch
from
c8bee20 to
3493551
Compare
pedro-stanaka
approved these changes
Sep 24, 2025
Contributor
pedro-stanaka
left a comment
pedro-stanaka
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #640.