Explicitly define the list of possible Desc for the prom client #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
/metricsendpoint returns a 500 caused by the errorcollected metric XXX with unregistered descriptor DescThe error comes from the fact that this service is using the prometheus Go client in a wrong way to initialize the
Descthat the service will expose. The possibleDescvalues are currently initialized in the prometheus library by callingprometheus.DescribeByCollecthere as part of the initialization of the service, and it works by collecting all the metrics once to get all the possibleDescvalues. The service here will only collect the metrics for the disks it managed to get stats for (here)This is a problem in various scenario, for example
Descare initialized at allWhen looking at the
prometheus.DescribeByCollectimplementation and documentation here, it's clear that this method should not be used by this service because of the use-case described in this issue.Fixes #326