Changes discussed under issue #19 #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests fail, instead of blocks of text.
aleading or trailing special character -for example a bracket) produces a leading or trailing underscore in the page title, which is invalid.
If amediawiki page title containes a colon or a slash, it was assuemd that this denotes a namespace. Now this checked ageinst the actual list of namespaces. Litteral colos nd slashes are also converted into underscores.
File links now work, file page links are still ignored
In case of localized File Aliasase, only the aliases, but not the canonical Alias was checked for, if a NamespaceLink was encountered. Links to file pages, starting with a colon were ignored. They are now converted into links to the respectve file. Simply by removing the leading colon.
-Headline levels were translated one level too low -alternative (piped) internal link names were not hnored, leaing to invalid links
Owner
|
Hi, Thanks for all these fixes. Sorry I neglected to reply for so long. I merged these against the current master and it mostly looks good, however I'm having a problem when importing some test wikis - namespaces aren't being correctly bought across, outcome that should be of the form namespace:xyz is coming over as namespace_xyz. I haven't had time to work out what the problem is (it might be in the merge rather than the changes you've supplied, there were a few conflicts). I've put it in a branch for now: If you have time I'd appreciate your input unravelling it, otherwise I'll hopefully get to it soon. Thanks again, Angus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.