Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ type Version struct {
}

func (v *Version) String() string {
return fmt.Sprintf("HTTP/%d.%d", v.Major, v.Minor)
if v.Major < 2 {
return fmt.Sprintf("HTTP/%d.%d", v.Major, v.Minor)
}
return fmt.Sprintf("HTTP/%d", v.Major)
}

var (
Expand Down
12 changes: 11 additions & 1 deletion client/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,23 @@ func (r *reader) ReadVersion() (Version, error) {
major = int(int(c) - 0x30)
}
case 6:
if c != '.' {
// For HTTP/2 and HTTP/3 there is no any '.', just do nothing
if c != '.' && major == 1 {
return readVersionErr(pos, '.', c)
}
if c != ' ' && (major == 2 || major == 3) {
return readVersionErr(pos, ' ', c)
}
if c == ' ' && (major == 2 || major == 3) {
return Version{Major: major, Minor: minor}, nil
}
case 7:
switch c {
case '0', '1', '2', '3', '4', '5', '6', '7', '8', '9':
minor = int(int(c) - 0x30)
case ' ':
// HTTP/2 case
minor = 0
}
case 8:
if c != ' ' {
Expand Down
42 changes: 37 additions & 5 deletions client/reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ type statusTest struct {
err bool
}

type versionTest struct {
name string
version string
major int
minor int
err bool
}

func TestStatusCode(t *testing.T) {
tests := []statusTest{
{"redirect 301", "301\r\n", 301, false},
Expand All @@ -25,11 +33,35 @@ func TestStatusCode(t *testing.T) {
{"invalid string", "aaa ", 0, true},
{"number with status text", "1234 unknown", 1234, false},
}

for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
r := reader{bufio.NewReader(strings.NewReader(test.statusLine))}
result, err := r.ReadStatusCode()
hasError := err != nil
require.Equal(t, test.err, hasError, err)
require.Equal(t, test.result, result)
})
}
}

func TestReadVersion(t *testing.T) {
tests := []versionTest{
{"HTTP/0.9", "HTTP/0.9 OK", 0, 9, false},
{"HTTP/1.0", "HTTP/1.0 OK", 1, 0, false},
{"HTTP/1.1", "HTTP/1.1 OK", 1, 1, false},
{"HTTP/2", "HTTP/2 OK", 2, 0, false},
}

for _, test := range tests {
r := reader{bufio.NewReader(strings.NewReader(test.statusLine))}
result, err := r.ReadStatusCode()
hasError := err != nil
require.Equal(t, test.err, hasError, err)
require.Equal(t, test.result, result)
t.Run(test.name, func(t *testing.T) {
r := reader{bufio.NewReader(strings.NewReader(test.version))}
result, err := r.ReadVersion()
hasError := err != nil
require.Equal(t, test.err, hasError, err)
require.Equal(t, strings.TrimSuffix(test.version, " OK"), result.String())
require.Equal(t, test.major, result.Major)
require.Equal(t, test.minor, result.Minor)
})
}
}