Skip to content

Fixing custom asset id upload #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsandeep merged 1 commit into from
Nov 7, 2025
Merged

Fixing custom asset id upload #2305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/httpx/httpx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,11 @@ func setupOptionalAssetUpload(opts *runner.Options) *pdcp.UploadWriter {
opts.OnClose = func() {
writer.Close()
}

// add additional metadata
if opts.AssetID != "" {
// silently ignore
_ = writer.SetAssetID(opts.AssetID)
writer.SetAssetID(opts.AssetID)
}
if opts.AssetName != "" {
// silently ignore
Expand Down
5 changes: 2 additions & 3 deletions internal/pdcp/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,11 @@ func (u *UploadWriter) GetWriterCallback() runner.OnResultCallback {
}

// SetAssetID sets the scan id for the upload writer
func (u *UploadWriter) SetAssetID(id string) error {
func (u *UploadWriter) SetAssetID(id string) {
if !xidRegex.MatchString(id) {
return fmt.Errorf("invalid asset id provided")
gologger.Warning().Msgf("invalid asset id provided (unknown xid format): %s", id)
}
u.assetGroupID = id
return nil
}

// SetAssetGroupName sets the scan name for the upload writer
Expand Down
Loading