Skip to content

feat: LabPolicyModal#26

Open
loghogjog wants to merge 2 commits intostagingfrom
LabPolicy
Open

feat: LabPolicyModal#26
loghogjog wants to merge 2 commits intostagingfrom
LabPolicy

Conversation

@loghogjog
Copy link
Contributor

ADD LABPOLICYMODAL

Copy link
Contributor

@DancinParrot DancinParrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor design changes to meet design system requirements.

Comment on lines +52 to +63
<div className="pb-6">
<label htmlFor="shutdown&disconnect" className="block mb-2 text-sm font-medium text-gray-900 dark:text-white">Automatic Shutdown & Disconnect</label>
<div className="flex items-center h-5 pb-4 pt-2">
<input type="checkbox" id="idle-machine" value={""} className="w-4 h-4 border border-gray-300 rounded bg-gray-50 focus:ring-3 focus:ring-blue-300 dark:bg-gray-700 dark:border-gray-600 dark:focus:ring-blue-600 dark:ring-offset-gray-800"></input>
<label htmlFor="idle-machine" className="block ml-2 text-sm font-medium text-gray-900 dark:text-white">Shutdown idle vitual machines</label>
</div>
<div className="flex items-center h-5 mb-6">
<div className="grid mt-6 grid-cols-4">
<input type="number" id="min-after-user-disconnect" className="col-span-1 bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-blue-500 focus:border-blue-500 block w-full p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-blue-500 dark:focus:border-blue-500" placeholder="10" required></input>
<label htmlFor="min-after-user-disconnect" className="col-span-3 block mt-2 ml-2 text-sm font-medium text-gray-900 dark:text-white">Minutes after user disconnects</label>
</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More spacing in between form elements
image


<div className="pb-6">
<div className="flex items-center h-5 pb-4">
<input type="checkbox" id="user-disconnect" value={""} className="w-4 h-4 border border-gray-300 rounded bg-gray-50 focus:ring-3 focus:ring-blue-300 dark:bg-gray-700 dark:border-gray-600 dark:focus:ring-blue-600 dark:ring-offset-gray-800"></input>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better checkbox styling
image

@DancinParrot DancinParrot linked an issue Jun 9, 2023 that may be closed by this pull request
@DancinParrot DancinParrot changed the title LabPolicyModal feat: LabPolicyModal Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User Flow Modals

2 participants