Conversation
SerVB
left a comment
SerVB
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I've taken a look and I can confirm that the translated strings are mostly match the original ones and have a similar meaning. Besides one typo, I don't see any problems and I think after fixing the typo, the PR can be merged, so I leave approval here. There are some minor comments though, probably worth taking resolving.
P.S.: I'm not an owner of the repo, so let's wait for a decision from the owner about merging...
PowerControlPanel/Classes/StartUp/Resources/StringResources.ru.xaml
Outdated
Show resolved
Hide resolved
| <system:String x:Key="Settings_GeneralSettings">Общие настройки</system:String> | ||
| <system:String x:Key="Settings_AMDSettings">Настрокйи AMD</system:String> | ||
| <system:String x:Key="Settings_IntelSettings">Настройки INTEL</system:String> |
There was a problem hiding this comment.
Why do we dropping CAPS LOCK here? Minor: probably should it match between translations...
| <system:String x:Key="Profiles_Name">Имя профиля</system:String> | ||
| <system:String x:Key="Profiles_OnCharger">Значения при работе от зарядного устройства</system:String> | ||
| <system:String x:Key="Profiles_OnBattery">Значения при работе от батареи</system:String> | ||
| <system:String x:Key="Profiles_ProfileApplications">Связанные приложения</system:String> |
There was a problem hiding this comment.
| <system:String x:Key="Profiles_ProfileApplications">Связанные приложения</system:String> | |
| <system:String x:Key="Profiles_ProfileApplications">Приложения профиля</system:String> |
Minor: more 1-to-1 translation would be like "Приложения профиля" ("Applications of the Profile"). The current translation "Связанные приложения" means something more like "Linked Applications", so it differs from the original string a bit more than it could
There was a problem hiding this comment.
Я попытался сохранить смысл. В данном случае идёт перечисление отдельных приложений, запускающихся при активации профиля. Думаю, в таком случае можно сказать, что они связаны
PowerControlPanel/Classes/StartUp/Resources/StringResources.ru.xaml
Outdated
Show resolved
Hide resolved
| <system:String x:Key="AppSettings_AppMain">Основные настройки приложения</system:String> | ||
| <system:String x:Key="AppSettings_RunApp">Запуск приложения</system:String> |
| <system:String x:Key="AppSettings_AppMain">Основные настройки приложения</system:String> | ||
| <system:String x:Key="AppSettings_RunApp">Запуск приложения</system:String> | ||
| <system:String x:Key="AppSettings_AppName">Имя приложения</system:String> | ||
| <system:String x:Key="AppSettings_SaveApp">СОХРАНИТЬ ПРИЛОЖЕНИЕ</system:String> |
There was a problem hiding this comment.
Minor: but here, we have lower case now...
There was a problem hiding this comment.
Я вообще не сторонник капса, но в данном случае идёт отделение кнопок от простых лейблов. Соответственно кнопки капсом, лейблы без капса
Co-authored-by: Sergei Bulgakov <servbul@yandex.ru>
2 participants
@project-sbc
Done, but I might need new build from you to check everything locally before making it public