fix: make sure fill defualts and expand args for all types #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so frontends can have their own args that the dalec core does not need to know about. This also moves the custom args for windowscross local to that implementation. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
improve_subst
branch
2 times, most recently
from
d797b36 to
eb8031a
Compare
adamperlin
reviewed
Dec 21, 2024
adamperlin
reviewed
Dec 21, 2024
Adds tests and fixes implementations where we weren't filling default values and expanding args. This was mostly a problem for anything under the `targets` section, but also a few other fields where arg expansion is nice to have (such as in test commands). Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
improve_subst
branch
from
eb8031a to
63dba93
Compare
1 task
adamperlin
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks 8cc2df0 from #480 to avoid merge conflicts
Adds tests and fixes implementations where we weren't filling default
values and expanding args.
This was mostly a problem for anything under the
targetssection, butalso a few other fields where arg expansion is nice to have (such as in
test commands).
Also splits some types/functions off to separate files so we don't have one mega file.
Fixes #479
Fixes #467