Skip to content

Fix goroutine leak #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morse255 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix goroutine leak #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 27 additions & 21 deletions maintenance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,32 +47,38 @@ func CreateConfig() *Config {
}

// Inform if there are hosts in maintenance
func Inform(config *Config) {
func Inform(ctx context.Context, config *Config) {
t := time.NewTicker(time.Second * config.InformInterval)
defer t.Stop()

for ; true; <-t.C {
client := http.Client{
Timeout: time.Second * config.InformTimeout,
}
for {
select {
case <-t.C:
client := http.Client{
Timeout: time.Second * config.InformTimeout,
}

req, _ := http.NewRequest(http.MethodGet, config.InformUrl, nil)
res, doErr := client.Do(req)
if doErr != nil {
log.Printf("Inform: %v", doErr) // Don't fatal, just go further
continue
}
req, _ := http.NewRequest(http.MethodGet, config.InformUrl, nil)
res, doErr := client.Do(req)
if doErr != nil {
log.Printf("Inform: %v", doErr) // Don't fatal, just go further
continue
}

defer res.Body.Close()
defer res.Body.Close()

decoder := json.NewDecoder(res.Body)
decodeErr := decoder.Decode(&hosts)
if decodeErr != nil {
log.Printf("Inform: %v", decodeErr) // Don't fatal, just go further
continue
}
decoder := json.NewDecoder(res.Body)
decodeErr := decoder.Decode(&hosts)
if decodeErr != nil {
log.Printf("Inform: %v", decodeErr) // Don't fatal, just go further
continue
}

log.Printf("Inform response: %v", hosts)
log.Printf("Inform response: %v", hosts)
case <-ctx.Done():
log.Printf("Inform complete")
return
}
}
}

Expand Down Expand Up @@ -137,8 +143,8 @@ func (rw *ResponseWriter) WriteHeader(statusCode int) {
rw.ResponseWriter.WriteHeader(http.StatusServiceUnavailable)
}

func New(_ context.Context, next http.Handler, config *Config, name string) (http.Handler, error) {
go Inform(config)
func New(ctx context.Context, next http.Handler, config *Config, name string) (http.Handler, error) {
go Inform(ctx, config)

return &Maintenance{
name: name,
Expand Down