-
Notifications
You must be signed in to change notification settings - Fork 114
Docs with mdbook & Github Pages #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jhollinger
wants to merge
36
commits into
release-2.0
Choose a base branch
from
jh/2.0-docs
base: release-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b92a4af to
a5da02f
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
V2 extension hooks and a hook runner
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
220e3c4 to
1cc2f4d
Compare
787fda2 to
6a03eab
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
6a03eab to
a0b0f69
Compare
Signed-off-by: Jordan Hollinger <jordan.hollinger@procore.com>
a0b0f69 to
f515f12
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
39c3a39 to
eee5367
Compare
eee5367 to
32852d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README for V1 is plenty lengthy as-is, and it will only get worse when we add docs for V2 and a guide for migrating. I propose that when we release the V2 API, we move our primary docs to Github Pages using mdbook. It's a Markdown static site generator written in, and maintained by, Rust. They use it for most of their docs and guides, and I've found it very pleasant to use in other projects. It has themes, full site search, and optional keyboard navigation.
I've begun writing V2 docs in this PR (even if we don't use mdbook, we can copy the markdown to something else, so it's hopefully not wasted effort). To test it out, I've enabled GH Pages for the repo and added a GH Action that publishes from this PR's branch. https://procore-oss.github.io/blueprinter/ Thoughts?