Add camera functions #47
Merged
+368
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catilac
approved these changes
Dec 23, 2025
Contributor
catilac
left a comment
catilac
left a comment
There was a problem hiding this comment.
lgtm! i love the way the modes are broken out. wonderous worlds ahead :P
Comment on lines
+368
to
+369
| // TODO: allow specifying up vector? | ||
| // does anyone actually use anything other than Vec3::Y here? |
Contributor
There was a problem hiding this comment.
fwiw I think it's fine to leave out specifying an up vector at least for now.
but gosh suddenly i want to see a sketch where the upvector changes over a time based function!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereq to doing anything useful with geometry.
I went back and forth about whether this should be a separate API object. But it's not in Bevy and so I think it's fine to express in terms of graphics here too. This is what Bevy calls "camera driven rendering", where the main graphics context is also a camera. There are pros and cons here but this is close to processing4 and so good enough for now, I think.