fix: unify playlist item short ID hash algorithm to SHA256#61
Open
fix: unify playlist item short ID hash algorithm to SHA256#61
Conversation
Replace unstable DefaultHasher with stable SHA256-based hashing in PlaylistItem::short_id() to ensure consistency with Runnable::PlaylistItem.short_id(). This fixes the hash mismatch where 'runbox playlist show' displayed different short IDs than 'runbox run' could resolve, making playlist item IDs unusable for running commands directly. Changes: - Export stable_short_id() from runnable.rs - Update PlaylistItem::short_id() to use the same SHA256 algorithm - All playlist item IDs are now stable across Rust versions Closes ISSUE-022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultHasherwith stable SHA256-based hashing inPlaylistItem::short_id()runbox playlist showandrunbox run <short_id>Problem
Playlist item short IDs displayed by
runbox playlist showcouldn't be used withrunbox run <id>:Root Cause
Two different hashing algorithms were used:
DefaultHasher(UNSTABLE across Rust versions)SHA256(STABLE)Solution
Unified on SHA256-based stable hash by:
stable_short_id()fromrunnable.rsPlaylistItem::short_id()to use the same algorithmAcceptance Criteria Evidence
All tests pass (121 core tests + 18 integration tests):
runbox playlist showdisplays same short IDs asrunbox list --type playlistrunbox run <short_id>works with IDs shown byrunbox playlist showCloses ISSUE-022